amogh-jahagirdar commented on code in PR #14480:
URL: https://github.com/apache/iceberg/pull/14480#discussion_r2517929126
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -533,11 +577,32 @@ protected <T extends RESTResponse> T execute(
throw new RESTException("Unhandled error: %s", error);
}
+ /**
+ * Supplied interface to allow RESTCatalogAdapter implementations to have a
mechanism to change
+ * how many file scan tasks get grouped in a plan task or under what
conditions a table scan
+ * should be performed async. Primarily used in testing to allow overriding
more deterministic
+ * ways of planning behavior.
+ */
+ public interface PlanningBehavior {
+ default int numberFileScanTasksPerPlanTask() {
+ return 100;
+ }
+
+ default boolean shouldPlanTableScanAsync(TableScan tableScan) {
+ return false;
+ }
+ }
+
+ protected PlanningBehavior planningBehavior() {
+ return new PlanningBehavior() {};
+ }
Review Comment:
Do we need a setter?
https://github.com/singhpk234/iceberg/pull/271/files#diff-37f64b622d5c3e0e890d94773e84ef49ceb3c1e9b0c03da313db9266b0e75afbR187
overriding should just work via inheritance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
