wgtmac commented on code in PR #296: URL: https://github.com/apache/iceberg-cpp/pull/296#discussion_r2516551157
########## src/iceberg/catalog/rest/http_client_interal.h: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <memory> +#include <string> + +#include <cpr/cpr.h> +#include <nlohmann/json.hpp> + +#include "iceberg/catalog/rest/config.h" +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/result.h" + +/// \file iceberg/catalog/rest/http_client.h +/// \brief Http client for Iceberg REST API. + +namespace iceberg::rest { + +/// \brief HTTP client for making requests to Iceberg REST Catalog API. +/// +/// This class wraps the CPR library and provides a type-safe interface for making +/// HTTP requests. It handles authentication, headers, and response parsing. +class ICEBERG_REST_EXPORT HttpClient { Review Comment: I think the major issue of this design is that `HttpClient` is not a real wrapper of the cpr client. We should design a library-independent interface of http client and should be super easy to replace the cpr library with any other network library without changing a single line in the `RestCatalog` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
