HeartLinked commented on code in PR #296:
URL: https://github.com/apache/iceberg-cpp/pull/296#discussion_r2554855860
##########
src/iceberg/test/rest_catalog_test.cc:
##########
@@ -93,7 +93,7 @@ TEST_F(RestCatalogTest, MakeCatalogWithCustomProperties) {
EXPECT_THAT(catalog_result, IsOk());
}
-TEST_F(RestCatalogTest, ListNamespaces) {
+TEST_F(RestCatalogTest, DISABLED_ListNamespaces) {
Review Comment:
Same reply as above.
##########
src/iceberg/test/rest_catalog_test.cc:
##########
@@ -82,7 +82,7 @@ TEST_F(RestCatalogTest, DISABLED_MakeCatalogEmptyUri) {
EXPECT_THAT(catalog_result, HasErrorMessage("uri"));
}
-TEST_F(RestCatalogTest, MakeCatalogWithCustomProperties) {
+TEST_F(RestCatalogTest, DISABLED_MakeCatalogWithCustomProperties) {
Review Comment:
Same reply as above.
##########
src/iceberg/test/rest_catalog_test.cc:
##########
@@ -61,7 +61,7 @@ class RestCatalogTest : public ::testing::Test {
RestCatalogConfig config_;
};
-TEST_F(RestCatalogTest, MakeCatalogSuccess) {
+TEST_F(RestCatalogTest, DISABLED_MakeCatalogSuccess) {
Review Comment:
Please see the comment above in line 33-34. This is a temporary integration
test that requires a local REST server, such as the Docker image
apache/iceberg-rest-fixture provided by Apache Iceberg. Currently, this method
allows testing locally, but it obviously cannot pass the Github CI process, so
it is a temporary expedient. In this first version PR, we clearly cannot
comprehensively complete such a large amount of work. If you are interested,
you can help complete this issue:
https://github.com/apache/iceberg-cpp/issues/333 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
