gbrgr commented on code in PR #1824:
URL: https://github.com/apache/iceberg-rust/pull/1824#discussion_r2517382300
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -523,6 +568,93 @@ impl ArrowReader {
Ok(results.into())
}
+ /// Helper function to add a `_file` column to a RecordBatch at a specific
position.
+ /// Takes the array, field to add, and position where to insert.
+ fn create_file_field_at_position(
Review Comment:
I sketched an approach in the record batch transformer, I took the path of
the transformer just having a `constant_map` stored which can be populated by
the reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]