gbrgr commented on code in PR #1824:
URL: https://github.com/apache/iceberg-rust/pull/1824#discussion_r2517385189
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -429,6 +471,27 @@ impl RecordBatchTransformer {
let vals: Vec<Option<f64>> = vec![None; num_rows];
Arc::new(Float64Array::from(vals))
}
+ (DataType::RunEndEncoded(_, _),
Some(PrimitiveLiteral::String(value))) => {
Review Comment:
Should we in general encode constant columns as REE? Or should we make this
custom per field? For the file path it definitely makes sense to run-end encode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
