danielcweeks commented on code in PR #14501:
URL: https://github.com/apache/iceberg/pull/14501#discussion_r2519381264
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -211,6 +213,27 @@ private ExecutorService executorService() {
return executorService;
}
+ private void deletePath(FileSystem fs, Path toDelete, boolean recursive)
throws IOException {
+ if (!shouldUseTrashIfConfigured()) {
+ fs.delete(toDelete, recursive);
+ return;
+ }
+ Trash trash = new Trash(fs, getConf());
+ if (!trash.isEnabled()) {
+ fs.delete(toDelete, recursive);
+ } else {
+ if (!recursive && fs.getFileStatus(toDelete).isDirectory()) {
Review Comment:
I feel like it would be better to not perform the check and allow a failure
from the HDFS/library to propagate up. The FileIO doesn't expose directory
operations and we don't delete directories, so I think this just introduces and
unnecessary call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
