danielcweeks commented on code in PR #14501:
URL: https://github.com/apache/iceberg/pull/14501#discussion_r2519386119
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -211,6 +213,27 @@ private ExecutorService executorService() {
return executorService;
}
+ private void deletePath(FileSystem fs, Path toDelete, boolean recursive)
throws IOException {
+ if (!shouldUseTrashIfConfigured()) {
+ fs.delete(toDelete, recursive);
+ return;
+ }
+ Trash trash = new Trash(fs, getConf());
+ if (!trash.isEnabled()) {
Review Comment:
If you can configure the trash at the Hadoop Conf level, why are we adding a
separate configuration? Shouldn't we just do this when the HadoopFileIO is
initialized and rely on the Hadoop trash conf? It feels like we're adding two
separate configs to enable trash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
