dingo4dev commented on code in PR #2220:
URL: https://github.com/apache/iceberg-python/pull/2220#discussion_r2526700386


##########
tests/integration/test_writes/test_writes.py:
##########
@@ -2089,6 +2091,7 @@ def test_read_write_decimals(session_catalog: Catalog) -> 
None:
     assert tbl.scan().to_arrow() == arrow_table
 
 
[email protected]("UUID BucketTransform is not supported in Spark Iceberg 
1.9.2 yet")

Review Comment:
   @raulcd, Thanks for your reviews. 
   
   Before this PR, the bucket transform is not test in this testcase because we 
found the issue in Iceberg Java. 
   
https://github.com/apache/iceberg-python/blob/f2131e6eea6fdd1158471e163e21c29dd23a3849/tests/integration/test_writes/test_writes.py#L2093-L2102
   
   My thoughts is using Trino to test this uuid partition testcase for Identity 
& Bucket Transforms, instead of using Spark Iceberg to test it, because the 
UUID Bucket Transform is not supported in Spark but it is worked in Trino. 
   
   To isolate the current issue in Java Iceberg, I added new testcase for it 
in: 
https://github.com/dingo4dev/iceberg-python/blob/3eef2566e02342d65a2c2f650bfb6c62d0221cf3/tests/integration/test_writes/test_writes.py#L2161
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to