raulcd commented on code in PR #2220:
URL: https://github.com/apache/iceberg-python/pull/2220#discussion_r2533125400
##########
tests/integration/test_writes/test_writes.py:
##########
@@ -2089,6 +2091,7 @@ def test_read_write_decimals(session_catalog: Catalog) ->
None:
assert tbl.scan().to_arrow() == arrow_table
[email protected]("UUID BucketTransform is not supported in Spark Iceberg
1.9.2 yet")
Review Comment:
I see, thanks for the comment. I understand you are adding a new test that
is covering both the `BucketTransform` and the `IdentityTransform` on
`test_uuid_partitioning_with_trino` but I don't think adding the conditional
skip on this specific test is necessary. Either we leave it as is, the test
will still run on non-trino set up or we remove it entirely as the transform is
covered on the trino setup. I would rather just maintain it to be honest
because if the Iceberg Java issue is fixed in the future we can just also add
the `BucketTransform` to run unconditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
