nastra commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2527837223
##########
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java:
##########
@@ -753,4 +769,167 @@ public void testIntegerNotIn() {
ManifestEvaluator.forRowFilter(notIn("no_nulls", "abc", "def"), SPEC,
true).eval(FILE);
assertThat(shouldRead).as("Should read: notIn on no nulls
column").isTrue();
}
+
+ /** Tests UUID equality filter using byte-order comparison against partition
bounds. */
+ @Test
+ public void testUuidEq() {
+ UUID belowMin = UUID.fromString("00000000-0000-0000-0000-000000000000");
+ boolean shouldRead =
+ ManifestEvaluator.forRowFilter(equal("uuid", belowMin), SPEC,
true).eval(FILE);
+ assertThat(shouldRead).as("Should not read: uuid below lower
bound").isFalse();
+
+ shouldRead =
+ ManifestEvaluator.forRowFilter(equal("uuid", UUID_MIN_VALUE), SPEC,
true).eval(FILE);
+ assertThat(shouldRead).as("Should read: uuid equal to lower
bound").isTrue();
+
+ UUID middle = UUID.fromString("7fffffff-ffff-ffff-7fff-ffffffffffff");
Review Comment:
```suggestion
UUID between = UUID.fromString("7fffffff-ffff-ffff-7fff-ffffffffffff");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
