nastra commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2533148335
##########
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java:
##########
@@ -119,24 +132,29 @@ public class TestInclusiveMetricsEvaluator {
.put(11, 0L)
.put(12, 1L)
.put(14, 0L)
+ .put(15, 0L)
.buildOrThrow(),
// nan value counts
ImmutableMap.of(
7, 50L,
8, 10L,
9, 0L),
// lower bounds
- ImmutableMap.of(
- 1, toByteBuffer(IntegerType.get(), INT_MIN_VALUE),
- 11, toByteBuffer(Types.FloatType.get(), Float.NaN),
- 12, toByteBuffer(Types.DoubleType.get(), Double.NaN),
- 14, toByteBuffer(Types.StringType.get(), "")),
+ ImmutableMap.<Integer, java.nio.ByteBuffer>builder()
Review Comment:
why is the change from `ImmutableMap.of(..)` to the builder needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
