zhjwpku commented on code in PR #319: URL: https://github.com/apache/iceberg-cpp/pull/319#discussion_r2527838039
########## README.md: ########## @@ -31,6 +31,8 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). - CMake 3.25 or higher - C++23 compliant compiler +> **Note**: For developers in China experiencing network issues when downloading dependencies, see [BUILD_CHINA.md](BUILD_CHINA.md) for mirror configuration. Review Comment: -1 from me. sorry about that :( One quick question: do other Apache projects handle this the same way for China? iceberg-cpp should build against system libraries dependencies, and I think that's probably the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
