Subham-KRLX commented on code in PR #319: URL: https://github.com/apache/iceberg-cpp/pull/319#discussion_r2528186112
########## README.md: ########## @@ -31,6 +31,8 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). - CMake 3.25 or higher - C++23 compliant compiler +> **Note**: For developers in China experiencing network issues when downloading dependencies, see [BUILD_CHINA.md](BUILD_CHINA.md) for mirror configuration. Review Comment: Thanks for the review! To clarify: this PR doesn’t introduce region specific behavior or change defaults. It only provides optional mirror URLs just like `ICEBERG_ARROW_URL` to make the build workable for developers in China who frequently hit GitHub timeouts. If preferred, I can simplify the PR so it only adds optional CMake variables + documentation, matching how other Apache projects handle this. Please let me know and I’ll update it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
