XJDKC commented on code in PR #14465:
URL: https://github.com/apache/iceberg/pull/14465#discussion_r2539581584
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -979,11 +980,11 @@ private String fullTableName(TableIdentifier ident) {
return String.format("%s.%s", name(), ident);
}
- private FileIO newFileIO(SessionContext context, Map<String, String>
properties) {
+ protected FileIO newFileIO(SessionContext context, Map<String, String>
properties) {
Review Comment:
Done, we can provide a ioBuilder like this:
```
class RESTCatalog {
// xxx
public RESTCatalog(
SessionCatalog.SessionContext context,
Function<Map<String, String>, RESTClient> clientBuilder) {
this.sessionCatalog = newSessionCatalog(clientBuilder, null);
this.delegate = sessionCatalog.asCatalog(context);
this.nsDelegate = (SupportsNamespaces) delegate;
this.context = context;
this.viewSessionCatalog = sessionCatalog.asViewCatalog(context);
}
RESTSessionCatalog newSessionCatalog(xxx) {
// replace this with the custom RESTSessionCatalog that provides the
custom Table Operations and custom IO Builder
return new RESTSessionCatalog(clientBuilder, new CustomIoBuilder());
}
// xxx
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
