nastra commented on code in PR #14465:
URL: https://github.com/apache/iceberg/pull/14465#discussion_r2560116538
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -44,10 +44,10 @@
import org.apache.iceberg.rest.responses.LoadTableResponse;
import org.apache.iceberg.util.LocationUtil;
-class RESTTableOperations implements TableOperations {
+public class RESTTableOperations implements TableOperations {
Review Comment:
I don't think we should update the visibility here. If somebody wants to
extend this class then that is still possible. The subclass just needs to be
inside the `org.apache.iceberg.rest` package. Concrete `TableOperations`
implementations are typically meant to be package-private and shouldn't be
exposed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
