CTTY commented on code in PR #1872:
URL: https://github.com/apache/iceberg-rust/pull/1872#discussion_r2542552168
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -137,6 +137,12 @@ impl TableProperties {
pub const PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES: &str =
"write.target-file-size-bytes";
/// Default target file size
pub const PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT: usize = 512 *
1024 * 1024; // 512 MB
+
+ /// Whether to use `FanoutWriter` for partitioned tables (handles unsorted
data).
+ /// If false, uses `ClusteredWriter` (requires sorted data, more memory
efficient).
+ pub const PROPERTY_WRITE_FANOUT_ENABLED: &str = "write.fanout.enabled";
Review Comment:
I think `write.datafusion.fanout.enabled` will be a better property name
since Java has
```java
public static final String SPARK_WRITE_PARTITIONED_FANOUT_ENABLED =
"write.spark.fanout.enabled";
```
##########
crates/iceberg/src/spec/table_properties.rs:
##########
Review Comment:
Should we add the new property here as well?
##########
crates/iceberg/src/spec/table_properties.rs:
##########
Review Comment:
We need to add the property here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
