CTTY commented on code in PR #1872: URL: https://github.com/apache/iceberg-rust/pull/1872#discussion_r2546585291
########## crates/iceberg/src/spec/table_properties.rs: ########## Review Comment: > write_format_default and write_target_file_size_bytes don't seem to be called by table_property.<property> and are manually parsed in write.rs Yes, this is because `table.metadata().properties()` is actually `&HashMap<String, String>`, not a `TableProperties` instance. There is an issue tracking this: https://github.com/apache/iceberg-rust/issues/1878 Once the issue above is fixed, we should definitely start thinking about standardize the way of fetching property. All of these can be treated as a separate issue imo, and we should still add the new properties to `TableProperties` struct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
