pvary commented on code in PR #14630:
URL: https://github.com/apache/iceberg/pull/14630#discussion_r2544991507


##########
core/src/main/java/org/apache/iceberg/InternalData.java:
##########
@@ -163,6 +164,11 @@ public interface ReadBuilder {
     /** Set a custom class for in-memory objects at the given field ID. */
     ReadBuilder setCustomType(int fieldId, Class<? extends StructLike> 
structClass);
 
+    /** Set a filter to apply on result rows if applicable. */
+    default ReadBuilder filter(Expression newFilter) {

Review Comment:
   nit: maybe call the parameter `filter`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to