pvary commented on code in PR #14630:
URL: https://github.com/apache/iceberg/pull/14630#discussion_r2544989615
##########
core/src/main/java/org/apache/iceberg/InternalData.java:
##########
@@ -163,6 +164,11 @@ public interface ReadBuilder {
/** Set a custom class for in-memory objects at the given field ID. */
ReadBuilder setCustomType(int fieldId, Class<? extends StructLike>
structClass);
+ /** Set a filter to apply on result rows if applicable. */
Review Comment:
It is very important to mention that the caller still needs to do residual
filtering, because some filters might not be supported, and some formats might
not support filtering at all.
Something like this:
```
/**
* Pushes down the {@link Expression} filter for the reader to prevent
reading unnecessary
* records. Some readers may not support filtering, or may only support
filtering for certain expressions.
* In this case the reader might return unfiltered or partially filtered
rows. It is the caller's responsibility to
* apply the filter again.
*
* @param filter the filter to set
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
