mxm commented on code in PR #14648:
URL: https://github.com/apache/iceberg/pull/14648#discussion_r2549546897


##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -136,8 +136,7 @@ public void prepareSnapshotPreBarrier(long checkpointId) 
throws IOException {
     }
 
     output.collect(
-        new StreamRecord<>(
-            new CommittableSummary<>(subTaskId, count, checkpointId, count, 
count, 0)));

Review Comment:
   Let's make sure that this constructor exists in all patch versions of Flink 
2.1.x. If it doesn't, we will crash. Similarly, for all other versions which we 
change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to