mxm commented on code in PR #14648:
URL: https://github.com/apache/iceberg/pull/14648#discussion_r2549789423
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -136,8 +136,7 @@ public void prepareSnapshotPreBarrier(long checkpointId)
throws IOException {
}
output.collect(
- new StreamRecord<>(
- new CommittableSummary<>(subTaskId, count, checkpointId, count,
count, 0)));
Review Comment:
Thanks for checking. We frequently had issues with the binary compatibility
of this class because it is marked @Experimental and changed between patch
releases, e.g. one of the parameters would change from Long to long. We
probably shouldn't directly depend on this class, but I don't think it is
possible to do that with the Sink V2 API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
