shangxinli commented on code in PR #334: URL: https://github.com/apache/iceberg-cpp/pull/334#discussion_r2556964003
########## src/iceberg/pending_update.h: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +/// \file iceberg/pending_update.h +/// API for table changes using builder pattern + +#include "iceberg/iceberg_export.h" +#include "iceberg/result.h" +#include "iceberg/type_fwd.h" + +namespace iceberg { + +/// \brief Non-template base class for table metadata changes using builder pattern +/// +/// This base class allows storing different types of PendingUpdate operations +/// in the same collection (e.g., in Transaction). It provides the common Commit() +/// interface that all updates share. +/// +/// This matches the Java Iceberg pattern where BaseTransaction stores a +/// List<PendingUpdate> without type parameters. +class ICEBERG_EXPORT PendingUpdateBase { + public: + virtual ~PendingUpdateBase() = default; + + /// \brief Apply and commit the pending changes to the table + /// + /// Changes are committed by calling the underlying table's commit operation. + /// + /// Once the commit is successful, the updated table will be refreshed. + /// + /// \return Status::OK if the commit was successful, or an error: + /// - ValidationFailed: if update cannot be applied to current metadata + /// - CommitFailed: if update cannot be committed due to conflicts + /// - CommitStateUnknown: if commit success state is unknown + virtual Status Commit() = 0; + + // Non-copyable, movable + PendingUpdateBase(const PendingUpdateBase&) = delete; + PendingUpdateBase& operator=(const PendingUpdateBase&) = delete; + PendingUpdateBase(PendingUpdateBase&&) noexcept = default; + PendingUpdateBase& operator=(PendingUpdateBase&&) noexcept = default; + + protected: + PendingUpdateBase() = default; +}; + +/// \brief Template class for type-safe table metadata changes using builder pattern +/// +/// PendingUpdate extends PendingUpdateBase with a type-safe Apply() method that +/// returns the specific result type for each operation. Subclasses implement +/// specific types of table updates such as schema changes, property updates, or +/// snapshot-producing operations like appends and deletes. +/// +/// Apply() can be used to validate and inspect the uncommitted changes before +/// committing. Commit() applies the changes and commits them to the table. +/// +/// \tparam T The type of result returned by Apply() +template <typename T> +class ICEBERG_EXPORT PendingUpdate : public PendingUpdateBase { Review Comment: Rename it ti PendingUpdateTyped -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
