smaheshwar-pltr commented on code in PR #14373:
URL: https://github.com/apache/iceberg/pull/14373#discussion_r2560884339
##########
core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithTransforms.java:
##########
@@ -259,6 +261,14 @@ public void testAllNulls() {
assertThat(shouldRead(notStartsWith(truncate("all_nulls_str", 10), "a")))
.as("Should read: notStartsWith on all null column")
.isTrue();
+
+ assertThat(shouldRead(endsWith(truncate("all_nulls_str", 10), "a")))
+ .as("Should skip: endsWith on all null column")
+ .isFalse();
Review Comment:
Pointing out that this differs to the assertion two lines above for the
`startsWith` case where this evaluates to true, and that's because of [this
logic](https://github.com/apache/iceberg/pull/14373/files#diff-089ec58f6b1412f14b2bc46786586fa28ff64e866ac5d1044fb8efc6c21df32aR476-R482)
that doesn't casework over a transform like `startsWith` does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
