smaheshwar-pltr commented on code in PR #14373:
URL: https://github.com/apache/iceberg/pull/14373#discussion_r2539625419
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##########
@@ -678,6 +678,10 @@ public <T> String predicate(UnboundPredicate<T> pred) {
return sqlString(pred.term()) + " LIKE '" + pred.literal().value() +
"%'";
case NOT_STARTS_WITH:
return sqlString(pred.term()) + " NOT LIKE '" +
pred.literal().value() + "%'";
+ case ENDS_WITH:
Review Comment:
Pointing out that this PR makes Spark changes only to Spark 4 - I intend to
follow up with a 3.5 backport (assuming folks are on board with this PR)
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -261,6 +261,39 @@ public void testBinPackWithFilter() {
assertEquals("Rows must match", expectedRecords, actualRecords);
}
+ @TestTemplate
+ public void testBinPackWithEndsWithFilter() {
Review Comment:
Wanted to test that the `endsWith` filter is correctly pushed down, hence
this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
