XJDKC commented on PR #14465: URL: https://github.com/apache/iceberg/pull/14465#issuecomment-3577853929
> Thank you for the PR and for answering my earlier questions about the use-case, @XJDKC! I see this is anticipated by a number of community members, so also fine by me. Just scratching the use-case a bit further, you mentioned extra logging and adding extra headers. Wouldn't it make sense to add the logging to the RESTTableOperations code and inject a header supplier or such that could take care of the extra headers. I know this is pretty late to the conversation, sorry, I don't intend to hold this back. Mainly asking for my own information so that I can understand the use-case better. > > I added some minor nits, and asked also for my information about the API stability guarantees for engines overriding the protected methods. Thanks! Not just about adding extra headers, but some other behaviors, e.g., audit logs, the way we get the credentials and some other catalog/storage properties, the way a specific platform perform transaction. These logic should not be included in iceberg sdk since it's specific to a platform. The reason for this PR is not about a specific use case, but making `RESTTableOperations` injectable in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
