rdblue commented on a change in pull request #1736:
URL: https://github.com/apache/iceberg/pull/1736#discussion_r518953565
##########
File path: api/src/test/java/org/apache/iceberg/util/RandomUtil.java
##########
@@ -31,6 +31,12 @@
private RandomUtil() {
}
+ private static final Random NEGATIVE_VALUES = new Random();
Review comment:
All tests need to use the `Random` that is passed in so that the values
that are generated are deterministic and repeatable. That's what allows us to
generated an iterator instead of a list in some cases, and makes it so if we do
have a problem, we can repeat the test and debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
