aokolnychyi commented on a change in pull request #1736:
URL: https://github.com/apache/iceberg/pull/1736#discussion_r518987239
##########
File path: api/src/test/java/org/apache/iceberg/util/RandomUtil.java
##########
@@ -155,15 +160,15 @@ public static Object
generateDictionaryEncodablePrimitive(Type.PrimitiveType pri
return true; // doesn't really matter for booleans since they are not
dictionary encoded
case INTEGER:
case DATE:
- return value;
+ return negate(value) ? -1 * value : value;
Review comment:
nit: extra space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
