pvary commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2571675847
##########
.palantir/revapi.yml:
##########
@@ -1456,6 +1456,12 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PartitionStats::deletedEntry(org.apache.iceberg.Snapshot)"
new: "method void
org.apache.iceberg.PartitionStats::deletedEntry(org.apache.iceberg.Snapshot)"
justification: "Changing deprecated code"
+ - code: "java.method.numberOfParametersChanged"
Review Comment:
Do we know why this constructor is protected? Is this just for testing, or
it is for possible extension classes?
I would create a new constructor, and deprecate the old one. This would help
us avoid breaking the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
