pvary commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2576767795
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -57,32 +60,83 @@ public static Catalog wrap(Catalog catalog, long
expirationIntervalMillis) {
public static Catalog wrap(
Catalog catalog, boolean caseSensitive, long expirationIntervalMillis) {
- return new CachingCatalog(catalog, caseSensitive,
expirationIntervalMillis);
+ return wrap(
+ catalog,
+ caseSensitive,
+ expirationIntervalMillis,
+ CatalogProperties.CACHE_EXPIRATION_POLICY_DEFAULT);
+ }
+
+ public static Catalog wrap(
+ Catalog catalog,
+ boolean caseSensitive,
+ long expirationIntervalMillis,
+ CacheExpirationPolicy cacheExpirationPolicy) {
+ return new CachingCatalog(
+ catalog, caseSensitive, expirationIntervalMillis,
cacheExpirationPolicy);
}
private final Catalog catalog;
private final boolean caseSensitive;
+ private final CacheExpirationPolicy cacheExpirationPolicy;
@SuppressWarnings("checkstyle:VisibilityModifier")
protected final long expirationIntervalMillis;
@SuppressWarnings("checkstyle:VisibilityModifier")
protected final Cache<TableIdentifier, Table> tableCache;
- private CachingCatalog(Catalog catalog, boolean caseSensitive, long
expirationIntervalMillis) {
- this(catalog, caseSensitive, expirationIntervalMillis,
Ticker.systemTicker());
+ private CachingCatalog(
+ Catalog catalog,
+ boolean caseSensitive,
+ long expirationIntervalMillis,
+ CacheExpirationPolicy cacheExpirationPolicy) {
+ this(
+ catalog,
+ caseSensitive,
+ expirationIntervalMillis,
+ Ticker.systemTicker(),
+ cacheExpirationPolicy);
}
+ /**
+ * Caching Catalog
+ *
+ * @deprecated will be removed in 2.0.0; use
+ *
org.apache.iceberg.CachingCatalog#CachingCatalog(org.apache.iceberg.catalog.Catalog,
Review Comment:
nit: AI? Why are we including full packages?
Should we remove this in 1.12.0?
Just raising the question—I’d like to hear others’ thoughts on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
