geruh commented on PR #2783: URL: https://github.com/apache/iceberg-python/pull/2783#issuecomment-3590708101
Looks good! I ran some additional JSON roundtrip tests against the existing ones in Iceberg's [TestExpressionParser](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/expressions/TestExpressionParser.java). It looks like all core expression types were serialized and deserialized correctly. Picking out the test cases that align with the REST spec, which are the boolean expressions, all the predicates, the and, or, and not operators, and nested expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
