kevinjqliu commented on code in PR #2783:
URL: https://github.com/apache/iceberg-python/pull/2783#discussion_r2566058713
##########
pyiceberg/transforms.py:
##########
@@ -431,8 +431,6 @@ def project(self, name: str, pred: BoundPredicate) ->
UnboundPredicate | None:
return _truncate_number(name, pred, transformer)
elif isinstance(pred, BoundIn): # NotIn can't be projected
return _set_apply_transform(name, pred, transformer)
- else:
- return None
Review Comment:
nit: for this and below, should we throw value error here? just in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
