geruh commented on PR #14677: URL: https://github.com/apache/iceberg/pull/14677#issuecomment-3590734096
Thanks you guys for the feedback!! The Expressions models have been around long before the REST scan planning API, and we've been using that parser for other things like the metrics scan report. I think it's definitely possible that folks have been calling or using the expression parser without any usage of the rest models. And in all those cases, the Java client has only ever written literal booleans for the true and false expressions. With that said, I don't think there's a way we can get out of this without breaking some clients. Even if we honor the REST spec by accepting the object form and keep writing Boolean literals. In that case, DuckDB will still need to handle reading the booleans. And then if we were to flip to writing in the object form, we'd break clients that are already relying on the booleans for scan report metrics. So, I'm I'm leaning towards allowing the deserialization of booleans, but keep the same behavior of serializing to boolean literals. but yeah, I just kind of want to make a point that regardless, we're going to be breaking clients here who have been accounting for both scenarios. Let me know what you all think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
