kevinjqliu commented on PR #14677: URL: https://github.com/apache/iceberg/pull/14677#issuecomment-3608692321
One nuance i missed, there are 2 issues here 1. string true vs boolean true 2. the "type" key [the spec](https://github.com/apache/iceberg/blob/bfe06a540d9d31d89b5161b20dcdcf6b1b6e2ef4/open-api/rest-catalog-open-api.yaml#L2266-L2273) expects `{"type": "true"}` while the [implementation](https://github.com/apache/iceberg/blob/bfe06a540d9d31d89b5161b20dcdcf6b1b6e2ef4/core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java#L276-L283) expect just `true` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
