rdblue commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519058611
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL =
"row-level-ops.isolation-level";
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL_DEFAULT =
"serializable";
+
+ public static final String ROW_LEVEL_OPS_MODE = "row-level-ops.mode";
+ public static final String ROW_LEVEL_OPS_MODE_DEFAULT = "copy-on-write";
Review comment:
Similar, how about `write.spark.mode`?
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeleteCheck.scala
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.expressions.{Expression, InSubquery, Not}
+import org.apache.spark.sql.catalyst.plans.logical.{DeleteFromTable,
LogicalPlan}
+
+object DeleteCheck extends (LogicalPlan => Unit) {
Review comment:
I think analysis check classes are usually named with "check" first,
like `CheckDeleteFromPredicate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
