rdblue commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519061728
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/SparkStreamingWrite.java
##########
@@ -40,7 +40,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class SparkStreamingWrite extends SparkBatchWrite implements
StreamingWrite {
+class SparkStreamingWrite extends BaseBatchWrite implements StreamingWrite {
Review comment:
In my changes for `RequiresDistributionAndOrdering`, this class went
away and is replaced by an inner class. I think that pattern worked well. Maybe
we could do that before this one to reduce the number of changes here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
