huaxingao commented on code in PR #14730:
URL: https://github.com/apache/iceberg/pull/14730#discussion_r2578243434
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -766,6 +768,8 @@ paths:
- Catalog API
summary: Cancels scan planning for a plan-id
operationId: cancelPlanning
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
Review Comment:
I think Idempotency-Key isn’t needed. Cancellation is already idempotent by
plan-id in the server. Repeated DELETEs converge to the same final state: if
the first attempt changed nothing, a retry clears everything; if it stopped
mid‑way, the next call removes whatever remains and flips SUBMITTED->CANCELLED
if still pending; if it already set CANCELLED, a retry just finishes any
remaining removals (no-op otherwise).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
