huaxingao commented on code in PR #14730:
URL: https://github.com/apache/iceberg/pull/14730#discussion_r2579264625
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -766,6 +768,8 @@ paths:
- Catalog API
summary: Cancels scan planning for a plan-id
operationId: cancelPlanning
+ parameters:
+ - $ref: '#/components/parameters/idempotency-key'
Review Comment:
Good point. Agree we should be consistent.
For delete, i think the first time it will return 204. For the 2nd time, if
we have idempotency key, it will return 204, but if we don't have idempotemcy
key, it returns 404. Is it better to return 204?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
