ebyhr commented on code in PR #2220:
URL: https://github.com/apache/iceberg-python/pull/2220#discussion_r2583421945
##########
dev/docker-compose-integration.yml:
##########
@@ -57,6 +57,21 @@ services:
- CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
- CATALOG_S3_ENDPOINT=http://minio:9000
- CATALOG_JDBC_STRICT__MODE=true
+
+ trino:
+ image: trinodb/trino:478
+ container_name: pyiceberg-trino
+ networks:
+ iceberg_net:
+ ports:
+ - 8082:8080
+ environment:
+ - CATALOG_MANAGEMENT=dynamic
+ depends_on:
+ - rest
+ - hive
+ volumes:
+ - ./trino/catalog:/etc/trino/catalog
Review Comment:
nit: How about specifying the full path of properties files? Thus, we can
use existing catalogs such memory and TPCH catalogs - they are helpful during
development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
