dingo4dev commented on code in PR #2220:
URL: https://github.com/apache/iceberg-python/pull/2220#discussion_r2597214132
##########
dev/trino/config.properties:
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I added `catalog.management=${ENV:CATALOG_MANAGEMENT}` to make sure it
consistence while someone updating `config.properties` explicitly. Or we can
just use `catalog.management=dynamic` and remove the env var.
##########
dev/docker-compose-integration.yml:
##########
@@ -57,6 +57,21 @@ services:
- CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
- CATALOG_S3_ENDPOINT=http://minio:9000
- CATALOG_JDBC_STRICT__MODE=true
+
+ trino:
+ image: trinodb/trino:478
+ container_name: pyiceberg-trino
+ networks:
+ iceberg_net:
+ ports:
+ - 8082:8080
+ environment:
+ - CATALOG_MANAGEMENT=dynamic
+ depends_on:
+ - rest
+ - hive
+ volumes:
+ - ./trino/catalog:/etc/trino/catalog
Review Comment:
Sounds great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
