liurenjie1024 commented on code in PR #1887:
URL: https://github.com/apache/iceberg-rust/pull/1887#discussion_r2584591464
##########
crates/sqllogictest/testdata/schedules/df_test.toml:
##########
@@ -20,4 +20,8 @@ df = { type = "datafusion" }
[[steps]]
engine = "df"
-slt = "df_test/show_tables.slt"
\ No newline at end of file
+slt = "df_test/show_tables.slt"
+
+[[steps]]
Review Comment:
nit: One schedule is used for a complete test case, maybe it's better to put
it in another schedule?
##########
crates/sqllogictest/src/engine/datafusion.rs:
##########
@@ -84,8 +85,74 @@ impl DataFusionEngine {
)
.await?;
+ // Create a test namespace for INSERT INTO tests
+ let namespace = NamespaceIdent::new("default".to_string());
+ catalog.create_namespace(&namespace, HashMap::new()).await?;
+
+ // Create test tables
+ Self::create_unpartitioned_table(&catalog, &namespace).await?;
Review Comment:
Why we don't do this using sql?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
