CTTY commented on code in PR #1887:
URL: https://github.com/apache/iceberg-rust/pull/1887#discussion_r2590415527
##########
crates/sqllogictest/src/engine/datafusion.rs:
##########
@@ -84,8 +85,74 @@ impl DataFusionEngine {
)
.await?;
+ // Create a test namespace for INSERT INTO tests
+ let namespace = NamespaceIdent::new("default".to_string());
+ catalog.create_namespace(&namespace, HashMap::new()).await?;
+
+ // Create test tables
+ Self::create_unpartitioned_table(&catalog, &namespace).await?;
Review Comment:
Discussed with @liurenjie1024 offline, that currently we don't support
`CREATE TABLE` yet and it should be ok to move forward with the pre-created
table. Plus these tables can be useful when testing `CREATE EXTERNAL TABLE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
