mxm commented on code in PR #14729:
URL: https://github.com/apache/iceberg/pull/14729#discussion_r2585505980
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -52,13 +52,19 @@ class TableMetadataCache {
private final long refreshMs;
private final int inputSchemasPerTableCacheMaximumSize;
private final Map<TableIdentifier, CacheItem> tableCache;
+ private final boolean caseSensitive;
Review Comment:
We would have to probe the catalog for both casings to make sure that we do
not load the wrong table. If the table exists for both cases, we would have to
throw an error, unless it is the same table. Catalogs don't seem to have a
notion of case insensitivity, in contrast to Schemas.
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -336,6 +337,15 @@ public Builder<T> inputSchemasPerTableCacheMaxSize(int
inputSchemasPerTableCache
return this;
}
+ /**
+ * Set whether schema field name matching should be case-sensitive. The
default is to match the
+ * field names case-sensitive.
+ */
+ public Builder<T> caseSensitive(boolean newCaseSensitive) {
Review Comment:
Thinking about it more, I'm not sure we should extend case insensitivity to
the table identifiers. It doesn't seem like catalogs currently have a notion of
case insensitivity, in contrast to Schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
