pvary commented on code in PR #14729:
URL: https://github.com/apache/iceberg/pull/14729#discussion_r2588930535
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -336,6 +337,15 @@ public Builder<T> inputSchemasPerTableCacheMaxSize(int
inputSchemasPerTableCache
return this;
}
+ /**
+ * Set whether schema field name matching should be case-sensitive. The
default is to match the
+ * field names case-sensitive.
+ */
+ public Builder<T> caseSensitive(boolean newCaseSensitive) {
Review Comment:
If we have a key which case sensitive, then this is making assumptions.
If we have a key which is case insensitive, then this is making assumptions.
In cache, we are fine if we are insensitive - we are just adding more items
to the cache.
During the commit retries, if we have 2 sets for a single table (upper case
and lower case), then we will not commit the 2nd set as the
lastCommittedCheckpointId is already increased when the 1st set was committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
