ethan-tyler opened a new pull request, #1898: URL: https://github.com/apache/iceberg-rust/pull/1898
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #1104 - Enables #1548 - Part of #1339 ## What changes are included in this PR? Adds support for committing position and equality delete files to Iceberg tables: Transaction layer: - DeleteAction - transaction action for committing delete files with Operation::Delete snapshot - Extends SnapshotProducer to write delete manifests (ManifestContentType::Deletes) - Validates format version (v2+ required), content types, equality_ids, partition specs Writer layer: - PositionDeleteFileWriter - writes position delete files with correct Iceberg field IDs - Tracks referenced_data_file for single-file deletes - Schema validation (file_path: string, pos: i64, non-nullable) API: - let tx = Transaction::new(&table); - let action = tx.delete().add_delete_files(delete_files); - let tx = action.apply(tx)?; - table = tx.commit(&catalog).await?; ## Are these changes tested? - 14 unit tests for DeleteAction (format version, content types, equality_ids, duplicates, partition validation, sequence numbers) - 13 unit tests for PositionDeleteFileWriter (schema validation, referenced_data_file, edge cases) - 1 integration test with REST catalog (end-to-end: write data → write position deletes → commit → verify scan filters deleted rows) <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
