kevinjqliu commented on issue #2792: URL: https://github.com/apache/iceberg-python/issues/2792#issuecomment-3614406033
Thanks for bringing this up! This looks like a good opportunity for some refactoring to match the scan planning api. I like option 2. Pydantic is great at serializing/deserializing (and validation!). We can use pydantic as the json decoder. I think it makes sense to create a `DataFile` class that both avro and json can reuse. One question about keeping the original `Record` behavior. Is it needed for `DataFile`? The `DataFile` class is created using `DataFile.from_args()` and accessed via its properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
