kevinjqliu commented on issue #2792: URL: https://github.com/apache/iceberg-python/issues/2792#issuecomment-3617854318
Answering my own question here about `Record`. Seems like this is from the Avro reader implementation https://github.com/apache/iceberg-python/blob/abae20f89fd88d761317267d7ceeb226e84a78ca/pyiceberg/manifest.py#L894-L900 These classes are essentially `avro.ManifestFile` / `avro.DataFile` and is directly serialized from the avro reader. What we want is something more generic, that can be serialized from both avro and json... Option 2 makes `DataFile` pydantic (json serializable) while keeping its `Record` behavior for avro serialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
