nastra commented on code in PR #14749:
URL: https://github.com/apache/iceberg/pull/14749#discussion_r2591757731
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2894,6 +2896,26 @@ public void testETagWithRegisterTable() {
assertThat(respHeaders).containsEntry(HttpHeaders.ETAG, eTag);
}
+ @Test
+ public void testLoadTableCredentials() {
+ RESTCatalogAdapter adapter = Mockito.spy(new
RESTCatalogAdapter(backendCatalog));
+ RESTCatalog catalog = catalog(adapter);
+
+ catalog.createNamespace(TABLE.namespace());
+ catalog.createTable(TABLE, SCHEMA);
+
+ List<Credential> credentials = catalog.loadTableCredentials(TABLE);
Review Comment:
the reason I haven't added the reference impl back then when introducing the
`/credentials` endpoint is because we can't really test it by going through the
catalog, since the catalog would never call this endpoint in its normal flow.
As I mentioned in
https://github.com/apache/iceberg/pull/14749/files#r2591733910 the only places
where this is called is in storage-specific code, which makes it difficult to
add a test here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
