rambleraptor commented on code in PR #14749:
URL: https://github.com/apache/iceberg/pull/14749#discussion_r2600086520
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1152,6 +1159,25 @@ public void commitTransaction(SessionContext context,
List<TableCommit> commits)
ErrorHandlers.tableCommitHandler());
}
+ public LoadCredentialsResponse loadTableCredentials(
Review Comment:
Alright, that makes sense. I've got a couple takeaways. Are these both
correct?
- Those credential providers are already using this endpoint (to get
credentials)
- We probably don't need this PR, since the reference implementation isn't
being used by the RESTCatalog at all. The "reference implementation" is at-best
a unit test for those listed providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
