pvary commented on code in PR #14728:
URL: https://github.com/apache/iceberg/pull/14728#discussion_r2592496794
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestEvolveSchemaVisitor.java:
##########
@@ -99,20 +104,76 @@ public void testMakeTopLevelPrimitivesOptional() {
assertThat(existingSchema.columns().stream().allMatch(Types.NestedField::isRequired)).isTrue();
UpdateSchema updateApi = loadUpdateApi(existingSchema);
- EvolveSchemaVisitor.visit(updateApi, existingSchema, new Schema());
+ EvolveSchemaVisitor.visit(TABLE, updateApi, existingSchema, new Schema(),
PRESERVE_COLUMNS);
Schema newSchema = updateApi.apply();
assertThat(newSchema.asStruct().fields()).hasSize(14);
assertThat(newSchema.columns().stream().allMatch(Types.NestedField::isOptional)).isTrue();
}
+ @Test
+ public void testDropUnusedColumns() {
Review Comment:
Could we have a test when the dropped column is inside a struct, array or
map?
Just to ensure that we traverse the hierarchy correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
