mxm commented on code in PR #14728: URL: https://github.com/apache/iceberg/pull/14728#discussion_r2592755838
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/EvolveSchemaVisitor.java: ########## @@ -36,30 +39,39 @@ * <li>Adding new columns * <li>Widening the type of existing columsn * <li>Reordering columns + * <li>Dropping columns (when dropUnusedColumns is enabled) * </ul> * * We don't support: * * <ul> - * <li>Dropping columns * <li>Renaming columns * </ul> Review Comment: If you don't mind, I keep this list with one element 😄 ########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/EvolveSchemaVisitor.java: ########## @@ -36,30 +39,39 @@ * <li>Adding new columns * <li>Widening the type of existing columsn * <li>Reordering columns + * <li>Dropping columns (when dropUnusedColumns is enabled) * </ul> * * We don't support: * * <ul> - * <li>Dropping columns * <li>Renaming columns * </ul> Review Comment: If you don't mind, I'll keep this list with one element 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
